Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut CORE and HYBRID entries from oceanspy/sciserver_catalogs/catalog_xarray.yaml #276

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

ThomasHaine
Copy link
Collaborator

Following #274 (comment)

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #276 (4e64b4f) into main (cef31e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files          10       10           
  Lines        3845     3845           
  Branches      812      812           
=======================================
  Hits         3664     3664           
  Misses        116      116           
  Partials       65       65           
Flag Coverage Δ
unittests 95.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@MaceKuailv MaceKuailv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am slightly confused by the fact that there is two PR. But I guess they will not overwrite each other.

@ThomasHaine
Copy link
Collaborator Author

Two PRs because I'm inept...

@ThomasHaine ThomasHaine reopened this Nov 13, 2022
@Mikejmnez Mikejmnez merged commit 38fc299 into main Nov 13, 2022
@Mikejmnez Mikejmnez deleted the ThomasHaine-patch-1-1 branch November 13, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants