Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add combine nested #279

Merged
merged 1 commit into from
Nov 22, 2022
Merged

add combine nested #279

merged 1 commit into from
Nov 22, 2022

Conversation

malmans2
Copy link
Contributor

@malmans2 malmans2 commented Nov 22, 2022

Closes #274

I think the datasets that are failing are experiencing a breaking change in xarray. We just have to specify combine="nested".

@ThomasHaine looks like you tested with a different environment. I couldn't reproduce the issue using the Oceanography Image on SciServer (I believe that's because that image uses an old version of xarray).
Could you please run your script again with this version of the catalog?
You just have to specify the catalog url corresponding to this branch:

catalog_url="https://raw.githubusercontent.com/hainegroup/oceanspy/add-combine/sciserver_catalogs/catalog_xarray.yaml"
od = ospy.open_oceandataset.from_catalog(name, catalog_url=catalog_url)

(where name is the name of the catalogue entry, such as IGPwinter)

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #279 (d359517) into main (a39fb85) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          10       10           
  Lines        3848     3848           
  Branches      812      812           
=======================================
  Hits         3660     3660           
  Misses        122      122           
  Partials       66       66           
Flag Coverage Δ
unittests 95.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ThomasHaine ThomasHaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for IGPwinter and EGshelfIIseas2km_ERAI_1D as expected.

@ThomasHaine ThomasHaine merged commit 486b16c into main Nov 22, 2022
@ThomasHaine ThomasHaine deleted the add-combine branch November 22, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sciserver_catalogs/datasets_list.yaml updates
2 participants