-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New year changes #300
Merged
Merged
New year changes #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pre-commit.ci] pre-commit autoupdate (hainegroup#296)
Mikejmnez
requested review from
malmans2,
renskegelderloos,
ThomasHaine,
MaceKuailv and
asiddi24
as code owners
December 30, 2022 00:14
Codecov Report
@@ Coverage Diff @@
## main #300 +/- ##
==========================================
+ Coverage 95.25% 95.74% +0.49%
==========================================
Files 9 9
Lines 3898 3928 +30
Branches 833 850 +17
==========================================
+ Hits 3713 3761 +48
+ Misses 116 97 -19
- Partials 69 70 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Dec 30, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues #285 , #291 and #299. In particular:
llc_rearrange.LLC_Transformation.arctic_crown
). As a result, the new od.grid of the resulting transformed dataset always hasinner
andouter
as grid_coords.find_cs_sn
fromospy.utils
.local_to_latlon
is replaced byllc_local_to_lat_lon
withinllc_rearrange
. This new function can rotate all vector fields and has a grid consistent with a staggered c-grid.viewer_to_range
can now take all arguments from poseidon viewer. Included tests for this.