Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix toml prettifier #307

Merged
merged 1 commit into from
Jan 9, 2023
Merged

fix toml prettifier #307

merged 1 commit into from
Jan 9, 2023

Conversation

malmans2
Copy link
Contributor

@malmans2 malmans2 commented Jan 9, 2023

@Mikejmnez see: macisamuele/language-formatters-pre-commit-hooks#133
It's not clear whether the project is actively maintained. We can also remove the hook, up to you.

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #307 (6684388) into main (013fe97) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files           9        9           
  Lines        3928     3928           
  Branches      850      850           
=======================================
  Hits         3761     3761           
  Misses         97       97           
  Partials       70       70           
Flag Coverage Δ
unittests 95.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Mikejmnez
Copy link
Collaborator

Thanks @malmans2!

We can also remove the hook, up to you.
Sure. Unless there is a reason to keep it, I'd remove it too.

@Mikejmnez
Copy link
Collaborator

Will wait until removing the hooks before merging

@malmans2
Copy link
Contributor Author

malmans2 commented Jan 9, 2023

It just lints our toml files, so no big deal if you get rid of it.

@Mikejmnez Mikejmnez merged commit b246cba into main Jan 9, 2023
@Mikejmnez Mikejmnez deleted the pin-toml branch January 9, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants