Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated cartopy property on notebook #311

Merged
merged 5 commits into from
Jan 19, 2023

Conversation

Mikejmnez
Copy link
Collaborator

@Mikejmnez Mikejmnez commented Jan 19, 2023

The goal of this PR is to close #310 . This PR accomplishes the following:

  • Replace background_patch with patch on Particles.ipynb notebook.
  • Update documentation (make html)
  • Replace xlabels_top by top_label and ylabels_right by right_labels on ospy.plot.horizontal_section().
  • Asses whether to set add_labels=True as default argument in od.plot.horizontal_section (and best way to do this), or to simply manually pass it as argument everytime one makes an horizontal section via od.plot module (for example, see cell 7 in https://oceanspy.readthedocs.io/en/latest/Kogur.html. Running this notebook as is on Sciserver does not plot the axis ticks nor labels).

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #311 (5d55302) into main (b7fd442) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files           9        9           
  Lines        3928     3928           
  Branches      850      850           
=======================================
  Hits         3761     3761           
  Misses         97       97           
  Partials       70       70           
Flag Coverage Δ
unittests 95.74% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oceanspy/plot.py 97.52% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ThomasHaine ThomasHaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge.

@ThomasHaine ThomasHaine merged commit ca26d81 into hainegroup:main Jan 19, 2023
@Mikejmnez
Copy link
Collaborator Author

I wasn't finished. Still missing a task (see first comment).

But these are minor issues with plotting and labels (ticks) not appearing unless add_labels is set True manually as an argument into od.plot.horizontal_section()

@ThomasHaine
Copy link
Collaborator

Doh! Sorry about jumping the gun.

@Mikejmnez Mikejmnez deleted the iss310 branch February 13, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oceanspy using background_patch (and other) deprecated cartopy properties
2 participants