Handle redirects from vault server versions earlier than v0.6.2 #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #75.
There are two golang HTTP related issues that are involved here, due to the way golang 1.7 http package reacts to HTTP redirects:
The first issue causes the
X-Vault-Token
header to be dropped when following redirects of HTTP GET requests. The second issue causes redirects on POST requests not to be followed at all.It does look like golang 1.8 will address both these issues once it is released... so these fixes are just needed in the meantime.
TODO:
PTAL: @hairyhenderson