Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map canvas stretches underneath the Drawer if map is loaded with drawer locked #1058

Closed
jacobwod opened this issue Apr 22, 2022 · 1 comment
Assignees
Labels
bug module:client/core Core functionality (not a plugin)
Milestone

Comments

@jacobwod
Copy link
Member

See title for description.

Below is a demonstration of the problem.

I show it in a 1366 px wide viewport. The map canvas should be 1366 when drawer is hidden, while 1366 minus drawer's width when it's visible. This works as intended when we toggle drawer.

However, if map starts with drawer visible and locked (i.e. "permanent"), the map canvas stretches underneath the drawer.


OK, no drawer, canvas as wide as the viewport:

Skärmavbild 2022-04-22 kl  09 35 19


OK, drawer locked and canvas gets narrowed down on the lock event:

Skärmavbild 2022-04-22 kl  09 35 31


Not OK: map loads with drawer already visible and locked but the map canvas occupies the invisible space underneath the drawer too. It shouldn't. It should be exactly as in the second screenshot.

Skärmavbild 2022-04-22 kl  09 35 43

@jacobwod jacobwod added bug module:client/core Core functionality (not a plugin) labels Apr 22, 2022
@jacobwod jacobwod added this to the 3.x milestone Apr 22, 2022
@jacobwod jacobwod modified the milestones: 3.x, 3.10 Apr 22, 2022
@jacobwod jacobwod self-assigned this Apr 22, 2022
@Hallbergs
Copy link
Member

Nice and simple fix, i like it! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug module:client/core Core functionality (not a plugin)
Projects
None yet
Development

No branches or pull requests

2 participants