Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side panel doesn't show the pre-selected chapter as marked #1132

Closed
jacobwod opened this issue Jul 8, 2022 · 2 comments
Closed

Side panel doesn't show the pre-selected chapter as marked #1132

jacobwod opened this issue Jul 8, 2022 · 2 comments
Assignees
Milestone

Comments

@jacobwod
Copy link
Member

jacobwod commented Jul 8, 2022

DocumentHandler's side panel should start with the selected chapter pre-marked in the side panel:
image
Correct behaviour in bae432a


Somewhere along the way, it seems that we lost this functionality. The same configuration files lead to this result on recent codebase:
Skärmavbild 2022-07-08 kl  08 50 25
Marker is lacking in newer releases, e.g. f172c2f


Quite a lot has happened in the code between these two points, including the upgraded MUI version. Probably we just missed some detail.

@jacobwod jacobwod added this to the 3.x milestone Jul 8, 2022
@jacobwod jacobwod assigned jacobwod and unassigned jacobwod Jul 8, 2022
@jacobwod
Copy link
Member Author

jacobwod commented Jul 8, 2022

So this is worrying: two pretty important props (document and model) are null:

image

@Hallbergs
Copy link
Member

Ugh. Probably some timing issue related to the react 18 upgrade. Let's look into it.

@jacobwod jacobwod modified the milestones: 3.x, 3.11 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants