Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infoclick: Be able to use x,y and zoom as params. #1145

Closed
jesade-vbg opened this issue Aug 23, 2022 · 6 comments · Fixed by #1163
Closed

Infoclick: Be able to use x,y and zoom as params. #1145

jesade-vbg opened this issue Aug 23, 2022 · 6 comments · Fixed by #1163
Assignees
Labels
new feature Request for adding/changing functionality
Milestone

Comments

@jesade-vbg
Copy link
Contributor

jesade-vbg commented Aug 23, 2022

We need the possibility to access and use {x}, {y} and {zoom} in infoclick templates to create links etc containing these.

Similar to: #1076 (comment)

Maybe group these as {click:param}

{click:x}
{click:y}
{click:zoom}

Edit:
I've also added the possibility to convert the coordinates to another projection.
Example:
{click:x|toProjection('x', 'click:x', 'click:y','EPSG:4326', 4)}
this converts x to EPSG:4326 (used by google etc)
{click:y|toProjection('y', 'click:x', 'click:y','EPSG:4326', 4)}
this converts y to EPSG:4326 (used by google etc)
So now you should be able to create links to a wide variety of map services.

@jesade-vbg jesade-vbg added this to the 3.x milestone Aug 23, 2022
@jacobwod
Copy link
Member

jacobwod commented Sep 1, 2022

@jesade-vbg Can you tag and mark as done please?

@jesade-vbg
Copy link
Contributor Author

Is this done? Have I missed something?

@jacobwod
Copy link
Member

jacobwod commented Sep 1, 2022

I thought it was completed in 3b565d8, but perhaps I mixed it up with something else? 😄

Edit: ahh.. it looks like two separate issues. Sorry!

@jesade-vbg
Copy link
Contributor Author

jesade-vbg commented Sep 2, 2022

I have a suggestion, to make AppModel a singleton. The AppModel is passed around in alot of places in the code. As there is only one AppModel instance that coders want to access, why not make it a singleton?

Whats your opinion? @Hallbergs @jacobwod

Check this commit:
e35b69d

@jesade-vbg jesade-vbg self-assigned this Sep 2, 2022
@jesade-vbg jesade-vbg added the new feature Request for adding/changing functionality label Sep 2, 2022
@jacobwod
Copy link
Member

jacobwod commented Sep 5, 2022

Interesting! Perhaps we can talk about this some day this week?

@jesade-vbg
Copy link
Contributor Author

image
AppModel and coordinate transforms seems trustworthy after refactoring. Transforms tested against GMaps and GStreetView.

@jesade-vbg jesade-vbg linked a pull request Sep 9, 2022 that will close this issue
@jesade-vbg jesade-vbg modified the milestones: 3.x, 3.11 Nov 9, 2022
@jacobwod jacobwod closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request for adding/changing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants