Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering in Admin UI crashes on some RegEx-specific characters ("(", "\", etc) #1158

Closed
jacobwod opened this issue Sep 5, 2022 · 0 comments
Assignees
Milestone

Comments

@jacobwod
Copy link
Member

jacobwod commented Sep 5, 2022

Typing a character in any filter field in Admin UI that can be interpreted as a valid modifier in a RegEx will lead to this crash:

Skärmavbild 2022-09-05 kl  16 10 45

The reason is that we seem to use the typed string directly as a regex expression, without previous sanitising. This should be fixed. Perhaps we don't need to use regular expressions at all anymore, for this very basic use case.

@jacobwod jacobwod added this to the 3.x milestone Sep 5, 2022
@jacobwod jacobwod self-assigned this Sep 5, 2022
@jacobwod jacobwod modified the milestones: 3.x, 3.11 Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant