Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print: add an option to append a margin #1174

Closed
OlofSvahnVbg opened this issue Sep 14, 2022 · 4 comments · Fixed by #1183
Closed

Print: add an option to append a margin #1174

OlofSvahnVbg opened this issue Sep 14, 2022 · 4 comments · Fixed by #1183
Assignees
@OlofSvahnVbg
Labels
module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality plugin:print
Milestone
3.11

Comments

@OlofSvahnVbg
Copy link
Collaborator

OlofSvahnVbg commented Sep 14, 2022 •
edited
Loading

User has asked to increase the marginals in the pdf-print function. Reason being; the icons and text now overlaps the map image, which renders them harder to discern. Marginals should be increased to fit the icons and text, so that they do not interfere with the map area:

This should be an option that can be turned on/off.

PDF with upper and lower margins
@OlofSvahnVbg OlofSvahnVbg added the new feature Request for adding/changing functionality label Sep 14, 2022
@OlofSvahnVbg OlofSvahnVbg added this to the 3.x milestone Sep 14, 2022
@OlofSvahnVbg OlofSvahnVbg self-assigned this Sep 14, 2022
@Hallbergs
Copy link
Member

Sounds good!

@jacobwod jacobwod added the module:client/plugin Functionality that goes into plugins in client label Sep 20, 2022
@OlofSvahnVbg
Copy link
Collaborator Author

New print marginal styling:
image

@OlofSvahnVbg
Copy link
Collaborator Author

Preview box in map view scales accordingly.
image

@OlofSvahnVbg
Copy link
Collaborator Author

OlofSvahnVbg commented Sep 21, 2022 •
edited
Loading

Added choice for text and icons in margins.
image

The button turns off if no margins are chosen above.
image

@OlofSvahnVbg OlofSvahnVbg mentioned this issue Sep 22, 2022
Merged
@jacobwod jacobwod modified the milestones: 3.x, 3.11 Sep 29, 2022
@jacobwod jacobwod changed the title PrintMarginal Print: add an option to append a margin Sep 29, 2022
@OlofSvahnVbg OlofSvahnVbg mentioned this issue Oct 5, 2022
Closed
@jacobwod jacobwod closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlofSvahnVbg OlofSvahnVbg

Labels
module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality plugin:print
Projects
None yet
Milestone
3.11
Development

Successfully merging a pull request may close this issue.

Feature/1174 print marginal hajkmap/Hajk
3 participants
@jacobwod @Hallbergs @OlofSvahnVbg