Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie notice needs better UI, especially on small screens #1223

Closed
jacobwod opened this issue Oct 20, 2022 · 1 comment
Closed

Cookie notice needs better UI, especially on small screens #1223

jacobwod opened this issue Oct 20, 2022 · 1 comment
Assignees
@jacobwod
Labels
focus:accessibility module:client/core Core functionality (not a plugin)
Milestone
3.11

Comments

@jacobwod
Copy link
Member

Describe the bug
Cookies notice UI is far from optimal on small screens.

Screenshots
Skärmavbild 2022-10-20 kl 10 22 09

Smartphone (please complete the following information):

  • Device: iPhone SE
  • OS: iOS 12.1
@jacobwod jacobwod added module:client/core Core functionality (not a plugin) focus:accessibility labels Oct 20, 2022
@jacobwod jacobwod added this to the 3.x milestone Oct 20, 2022
@jacobwod
Copy link
Member Author

Solved

Skärmavbild 2022-10-20 kl 11 27 27

On big screens

Skärmavbild 2022-10-20 kl 11 26 48

Edge cases

There will be some edge cases like this, especially since you can customise the text (as well as once you can set another language - there's no point of controlling the exact width of the buttons since we can not know the length of the text).
Skärmavbild 2022-10-20 kl 11 29 14

Feel free to contribute and fix the edge cases!

@jacobwod jacobwod self-assigned this Oct 20, 2022
@jacobwod jacobwod modified the milestones: 3.x, 3.11 Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobwod jacobwod

Labels
focus:accessibility module:client/core Core functionality (not a plugin)
Projects
None yet
Milestone
3.11
Development

No branches or pull requests
1 participant
@jacobwod