Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min/max zoom level - Checkboxes do not turn red for group layers when outside zoom level #1290

Open
elizabethgbg opened this issue Feb 20, 2023 · 2 comments
Assignees
Labels
Milestone

Comments

@elizabethgbg
Copy link

elizabethgbg commented Feb 20, 2023

Bug description for group layers
When you zoom outside a specified zoom level and switch on a single layer, the checkbox in the layer manager turns red. When you are outside a specified zoom level and switch on a group layer, the checkbox in the layer manager does not turn red.

Expected behavior and wishes for group layers
That the indicator (red color in checkboxes) that shows that you have zoomed outside a specified zoom level, work the same on group layers as for individual layers. So that red checkboxes is displayed when the layer is lit outside the zoom level.

This is a clarification of the bugs described in #810
Related issues: #1291, #1299, #1300

@linusfj linusfj self-assigned this Feb 21, 2023
@elizabethgbg
Copy link
Author

elizabethgbg commented Mar 17, 2023

Concerning checkboxes for "group layer names" there are two different options:

Option 1: the group layer names checkbox is also colored red when zooming outside the layers specified zoom level/switching on layers in the group outside the specified zoom level.
Option 1

Option 2: the group layer names checkbox is not colored red when zooming outside the layers specified zoom level/switching on layers in the group outside the specified zoom level. The checkbox remains black/grey.
Option 2

We believe that all group checkboxes in the layer manager should have the same behavior when zooming outside a layers specified zoom level/switching on layers outside the specified zoom level. Currently, the checkboxes for groups remain black/grey when doing this.

Since it is not possible for users to distinguish between groups and group layer names in the layer manager, we believe that group layer names should be treated as groups in this regard. For this reason, we currently plan to proceed with option number two.

Please let us know if you have any thoughts on this!

@jacobwod
Copy link
Member

Good issue description!

I think I see what you mean – currently groups can never turn orange or orange-gray (when partly toggled). E.g. in this case user could expect an orange-gray toggle box, since the group is partly toggled and at least one of its layers can not be shown:
Skärmavbild 2023-03-20 kl  08 13 51

And you want to copy this behaviour in group layers too? That's how I read the option 2 you mention.

In that case it's fine and valid.

It would, of course, be even better to actually fix (both groups and group layers) to have an orange-gray state. 😄


As a side note: there's a slight typo in the linked branch's name (fix/1290/checkbox-indicator-group-layers). We usually use slash as a separator and dash as a joining character within the name. Please keep this in mind when creating branches in the future. (I.e. fix/1290-checkbox-indicator-group-layers would be correct in this case.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants