Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend/ActiveDirectory: let connection checker use a separate AD instance, make the checker optional #1342

Closed
jacobwod opened this issue Jun 1, 2023 · 0 comments
Assignees
Labels
module:backend MapService stuff
Milestone

Comments

@jacobwod
Copy link
Member

jacobwod commented Jun 1, 2023

Documentation

To control whether a initial connection from the backend to the configured LDAP server is being attempted, use this setting in .env:

AD_CHECK_CONNECTION=true

It defaults to true when unset.

Original issue

I'm working on implementing two of the proposed changes that came up during today's meeting:

  1. Make the #checkConnection method optional, the .env key will be called AD_CHECK_CONNECTION and default to true
  2. Separate the connection checker ActiveDirectory instance from the main instance. The reason is that if the main instance has the LDAPJS option reconnect set to true, this check never fails (see Getting map config for restricted map can sometimes fail and return [ERROR] service.auth.v2 - read ECONNRESET #1320 (comment)). Using a separate instance, where reconnect: false; is hard-coded seems a safer approach.

Originally posted by @jacobwod in #1320 (comment)

@jacobwod jacobwod self-assigned this Jun 1, 2023
@jacobwod jacobwod added the module:backend MapService stuff label Jun 1, 2023
@jacobwod jacobwod modified the milestones: 3.x, 3.12 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:backend MapService stuff
Projects
None yet
Development

No branches or pull requests

1 participant