Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfoClick: Resize breaks scroll #1428

Closed
jesade-vbg opened this issue Nov 1, 2023 · 6 comments
Closed

InfoClick: Resize breaks scroll #1428

jesade-vbg opened this issue Nov 1, 2023 · 6 comments
Assignees
Labels
Milestone

Comments

@jesade-vbg
Copy link
Contributor

If you resize the infoclick windows height, you wont be able to view all content in the window.
Somewhere in the code it sets the window content height to a fixed px value, which in return does not get updated when the window resizes.

The right window shows the broken scroll window.
image

@jesade-vbg jesade-vbg added the bug label Nov 1, 2023
@jesade-vbg jesade-vbg added this to the 3.x milestone Nov 1, 2023
@jacobwod
Copy link
Member

jacobwod commented Nov 1, 2023

If I recall correctly, this does affect all components based on Window.js. It's more difficult to discover in plugins' windows, as they'r content's height usually doesn't change, but I remember I noticed it somewhere. Test and see. 😄

Anyway, yes, that's a valid bug.

@jacobwod
Copy link
Member

jacobwod commented Nov 3, 2023

BTW, I'm looking into a similar issue and found that display: "contents" seems to be what breaks scrolling (in my case, I'm not sure it's the same as yours). Try reverting the change introduced in this commit (d979135) and see if it helps.

@jesade-vbg
Copy link
Contributor Author

I might have a tiny quick-fix/patch to get this working for now. Will create branch.

@jesade-vbg
Copy link
Contributor Author

@jesade-vbg jesade-vbg self-assigned this Feb 2, 2024
@jacobwod
Copy link
Member

jacobwod commented Feb 9, 2024

Hey @jesade-vbg, feel free to PR & merge when ready!

@jesade-vbg
Copy link
Contributor Author

jesade-vbg commented Feb 9, 2024

Oh! I've forgotten about this one :) Will do PR & Merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants