-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of Babel for back-end build inhibits building Hajk on Windows #1483
Comments
Interesting. It sure looks like that. The main reason for this to get unnoticed for so long is the fact that most of the active developers in Hajk either uses bash or similar, or git-bash on windows. |
Nice catch! As @jesade-vbg said, i've missed it since im using bash |
Yes sure, me too (git-bash). Not a problem, I just stumbled accross this and will contribute a small shx fix. |
Great! 🥳 |
* Re-introduces e.g. Windows CMD compile capability for Hajk's back-end * Fixes hajkmap#1483 after Babel removal (Hajk's RFC1/2 clean-up project)
* Re-introduces e.g. Windows CMD compile capability for Hajk's back-end * Fixes hajkmap#1483 after Babel removal (Hajk's RFC1/2 clean-up project)
Valid point. We actually talked about it today and thought that "everyone [read: everyone who is an active Hajk developer uses Git bash anyway, so go for POSIX-style commands". 😄 But obviously there are cases (build chain) where we end up with CMD and the current commands won't work. I trust you regarding the proposed solution ( Just out of curiosity: wouldn't current commands work on PowerShell? Or is it that CMD is still the standard shell on Windows? |
@jacobwod Sorry, missed your question. No unfortunately the "rm -rf" command does not work in PowerShell either. There is a simple "rm" alias in PS as well as "rmdir" but they both refer to Remove-Item cmdlet that can't parse the combined parameters. The current Hajk cp command would work in PS since that is a Copy-Item alias and using only one command-line parameter allows for the abbreviation to work so "cp -r" is PS-compatible. (But e.g. "cp -fr" would not be, it would have to be "cp -f -r" (=Copy-Item -Force -Recursive) in PS - pretty stupid, but that's how it is...). Regarding standard console it's highly dependent on deploy pipeline/process so to be flexible for Windows Server it's recommended that Hajk can handle both. |
Thanks and no worries @sweco-semara! 😄 It's merged and confirmed working as intended (here, in ZSH): |
Describe the bug
Since removal of Babel for dist-copy of back-end, Hajk no longer builds with a standard Windows toolchain.
To Reproduce
Expected behavior
Expect cross-platform build scripts.
Additional context
Should be a minor fix to reintroduce cross-platform build. E.g. using rimraf for recursive dist removal and conditional copy commands for recursive server to dist copy, or just using shx as a devDependency to get *nix style tools availability in a cross-platform manner.
The text was updated successfully, but these errors were encountered: