Feature/orebro tsm #1228
Merged
Feature/orebro tsm #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobwod
requested changes
Nov 3, 2022
| featureProps[field.name] || field.defaultValue || ""; | ||
| //Object that returns as a string results in [object] [Object] | ||
| if ( | ||
| JSON.stringify(featureProps[field.name]) === '{"xsi:nil":"true"}' |
There was a problem hiding this comment.
To be honest, I don't see why you compare a stringified object, instead of just
featureProps[field.name]?.["xsi:nil"] === true
There was a problem hiding this comment.
I'll write like this then:
featureProps[field.name]?.["xsi:nil"] === "true"
? (valueMap[field.name] = "")
: (valueMap[field.name] =
featureProps[field.name] || field.defaultValue || "");
Then it seems to work
Pushed
jacobwod
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #987
QGIS server returns object that is not empty. HAJK prints out object as string which returns Object Object in fields (text och siffra).
Filename: AttributeEditor.js in new-client/src/plugins/Edit/components