Dop develop #937
Dop develop #937
Conversation
…cument-Handler-new-tags
…ndlerprint-print-menu
…cument-Handler-new-tags
…ndlerprint-print-menu
…nt-menu' into dop-develop
page break after table of contents
replace relative urls in print
correctly toggle parents
|
Correct me if I'm wrong but this looks like a bulk PR? My understanding was that in the begging of the project we decided that you'd push smaller changes more frequently? |
|
You are right that this PR is a big one and you are also right that our intention was different. Unfortunately, it was not a feasible course of action that we could apply. |
|
Just a quick update. Will take a look at this tomorrow! |
|
Great, please let me know if I can help. |
|
The printout itself works and is looking good! The Admin UI, however, refuses to load since you haven't implemented the new endpoints in the NodeJS Backend. What's your opinion on this? Was handling of video and audio tags only ment to work in the .NET backend? If so, why did you add the new endpoints to the "list_videos": "/api/v1/mapconfig/listvideo",
"list_audio": "/api/v1/mapconfig/listaudio"This will not work and will lead to the Docker container crashing, as it's NodeJS backend-only. |
|
We have fixed the lint warning messages in admin and added routes for video and audio in the new backend. There is no file type checking for the audio/video routes (same as the existing image route). |
| if (Path.GetExtension(file).ToLower() == ".mp4" || Path.GetExtension(file).ToLower() == ".mov" || Path.GetExtension(file).ToLower() == ".ogg") | ||
| { | ||
| fileName = Path.GetFileName(file); | ||
| if (fileName != "layers") |
There was a problem hiding this comment.
To diffrate pictures from videos etc. that are in the same folder.
There was a problem hiding this comment.
I think @jacobwod is referring to the if (fileName != "layers") part. The configuration files are not in the same folder as the upload-data, right?
There was a problem hiding this comment.
Correct, the configuration files are not in the Upload folder, only data files such as images and videos. I guess this line is from an previous iteration of DOP.
There was a problem hiding this comment.
I will fix this issue and update the PR with that fix.
A PR for document handler. Added new tags and updated the print function.