Add Bootstrap 3 and 4 to the test folder #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terales
changed the title
|
@hakimel I second this as it would remove the need for many other repos floating around Github that are not constantly up to date (including mine) and will provide a nice starting point for people integrating Ladda into Bootstrap projects. |
|
I'm all for including additional examples if it makes it easier for people to get started with Ladda. Thanks for the PR 🙌 |
|
this is not bootsrap 4! |
|
@vahidalvandi sure, now it's different. You're free to submit a PR with an updated test case for Bootstrap 4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ladda works well out of box:
Maybe we should include them into a test folder?