New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
share video accross multiple slides or fragements w/o restarting the video #2882
Comments
I have what I believe is the same issue, but for ordinary videos, not background videos. When a |
Multiple identical & consecutive background videos will now keep playing without interruption as of a29a9c7 I have not been able to reproduce the issue with fragments restarting videos so assuming that's already been fixed. |
I don't think so, on master there is this: reveal.js/js/controllers/slidecontent.js Lines 310 to 312 in a29a9c7
I believe this runs unconditionally when a fragment is advanced, and causes all videos on the slide to restart. |
@rben01 The I did noticed that videos were resetting when hiding fragments though, and perhaps there are other cases I've missed. I pushed a small change that should guard against resetting any video that is already playing: 1748a55#diff-bc5fdf2e5a37c0d28014f2a2d06dfe42bd43718f3aed85e434dcc5b66dcb7556R378-R382 |
Yes, Separately, I'm not sure if restarting videos that have finished playing is the right call — I would imagine that some people would like them to play once and never restart. Could this be controlled with an attribute like |
Hi,
I just found that sharing a background video accross multiple slides or fragments restarts the video.
Is there a way to not restart the video but just keep it running?
Examples
share video accross multiple slides
If switching from the first to the second slide, the video restarts from the beginning.
I'd rather like to keep it running and not restarting it.
share video with fragments
If switching to the second fragment the video restarts from the beginning.
I'd rather like to keep it running and not restarting it.
any ideas?
The text was updated successfully, but these errors were encountered: