Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile navigation broken when data-fragment-index skips index 0 #3540

Closed
FlippingBinary opened this issue Nov 27, 2023 · 1 comment
Closed

Comments

@FlippingBinary
Copy link

This seems to only affect mobile navigation, even as simulated in Vivaldi on Windows 10. When the data-fragment-index property is set to something higher than 0 and there is no element with a data-fragment-index of 0, the pages won't swipe.

Here is the error that appears in the browser console:

scrollview.js:431 Uncaught TypeError: Cannot set properties of undefined (setting 'range')
    at scrollview.js:431:19
    at Array.forEach (<anonymous>)
    at scrollview.js:430:32
    at Array.forEach (<anonymous>)
    at L.setTriggerRanges (scrollview.js:421:22)
    at L.syncPages (scrollview.js:379:8)
    at L.layout (scrollview.js:257:9)
    at Object.Be [as layout] (reveal.js:1037:15)
    at L.activate (scrollview.js:133:15)
    at Be (reveal.js:1025:47)

The obvious solution is to fix the data-fragment-index assignments in the presentation, but it wasn't obvious that this was the reason why slide navigation broke on mobile. I hope this helps someone else.

hakimel added a commit that referenced this issue Nov 30, 2023
@hakimel
Copy link
Owner

hakimel commented Nov 30, 2023

Thanks for the report! Fixed in d5896c9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants