Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix search plugin ignoring diacritics #3532

Conversation

t-fritsch
Copy link
Collaborator

allows searching for diacritics as asked in #3492

to test it :

  1. npm start
  2. add a slide in the demo.html file :
    <section>
        <h2>DIACRITICS SEARCH</h2>
        <p style="word-wrap: break-word">
            ÁĂẮẶẰẲẴǍÂẤẬẦẨẪÄẠÀẢĀĄÅǺÃÆǼBḄƁʚɞCĆČÇĈĊƆʗDĎḒḌƊḎDzDžĐÐDZDŽEÉĔĚÊẾỆỀỂỄËĖẸÈẺĒĘẼƐƏFƑ
            GǴĞǦĢĜĠḠʛHḪĤḤĦIÍĬǏÎÏİỊÌỈĪĮĨIJJĴKĶḲƘḴLĹȽĽĻḼḶḸḺĿLjŁLJMḾṀṂNŃŇŅṊṄṆǸƝṈNjÑNJOÓŎǑÔỐỘỒỔỖÖỌ
            ŐÒỎƠỚỢỜỞỠŌƟǪØǾÕŒɶPÞQRŔŘŖṘṚṜṞʁSŚŠŞŜȘṠṢẞTŤŢṰȚṬṮŦÞÐUÚŬǓÛÜǗǙǛǕỤŰÙỦƯỨỰỪỬỮŪŲ
            ŮŨVWẂŴẄẀʬXYÝŶŸẎỴỲƳỶȲỸZŹŽŻẒẔƵlaáăắặằẳẵǎâấậầẩẫäạàảāąåǻãæǽɑɐɒbḅɓßcćčçĉɕċdďḓḍɗḏđɖʤdzʣ
            ʥdžðeéĕěêếệềểễëėẹèẻēęẽʒǯʓɘɜɝəɚʚɞfƒſʩfiflʃʆʅɟʄgǵğǧģĝġɠḡɡɣhḫĥḥɦẖħɧɥʮʯųiíĭǐîïịìỉīįɨĩɩıijɟjǰĵʝȷɟʄkķḳƙḵĸʞlĺƚɬ
            ľļḽḷḹḻŀɫɭłƛɮljʪʫmḿṁṃɱɯɰnʼnńňņṋṅṇǹɲṉɳñnjŋŊoóŏǒôốộồổỗöọőòỏơớợờởỡōǫøǿõɛɔɵʘœpɸþqʠrŕřŗṙṛṝɾṟɼɽɿɹɻɺ
            sśšşŝșṡṣʂſʃʆßʅtťţṱțẗṭṯʈŧʨʧþðʦʇuʉúŭǔûüǘǚǜǖụűùủưứựừửữūųůũʊvʋʌwẃŵẅẁʍxyýŷÿẏỵỳƴỷȳỹʎzźžʑżẓẕ
            ƶIǂʭʔʡʖǁʕǃʢ
        </p>
    </section>
  3. load presentation in browser http://localhost:8000/demo.html
  4. using search plugin, search for any diacritic, it should navigate to this slide and highlight the right text

Please note that it may not work for every diactritics in every character set (only tested on latin diacritics).
Anyway maybe the discussion opened at #2331 can make the problem much simpler if we decide to search any character without altering the user input string.

fixes #3492

@hakimel
Copy link
Owner

hakimel commented Nov 23, 2023

Appreciate you taking the time to look into this @t-fritsch. I agree with your conclusion that we should allow searching for any character. I've addressed this in master via 339dc70 + 20d9eaf

@hakimel hakimel closed this Nov 23, 2023
@t-fritsch
Copy link
Collaborator Author

you're welcome ! thanks for the fix :)

@t-fritsch t-fritsch deleted the fix-revealsearch-broken-with-diacritics branch November 23, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RevealSearch plugin can't find diacritics character
2 participants