Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored var to let or const, used strict equality operator #3454

Merged
merged 1 commit into from Aug 22, 2023

Conversation

grgprarup
Copy link
Contributor

While working with the markdown plugin, I've seen some semantic errors so fixed them. The changes are done in markdown plugin only.
The changes made in this PR:

  • Refactored to replace var declarations with let or const for better variable management
  • Refactored the code to replace == with === and != with !==

@hakimel hakimel merged commit bae6de8 into hakimel:master Aug 22, 2023
@hakimel
Copy link
Owner

hakimel commented Aug 22, 2023

Thanks!

@t-fritsch
Copy link
Collaborator

great work !
@hakimel shouldn't the plugin/markdown/markdown.js and plugin/markdown/markdown.esm.js files get updated too (or maybe it is part of a github action/git hook somewhere) ?

hakimel added a commit that referenced this pull request Aug 23, 2023
@hakimel
Copy link
Owner

hakimel commented Aug 23, 2023

@t-fritsch Thanks for the reminder, I just recompiled them.

@t-fritsch
Copy link
Collaborator

you're welcome ! I wasn't sure this was the way 😅

@grgprarup grgprarup deleted the refactor-vars-and-equality branch September 14, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants