Skip to content

Commit

Permalink
[stable/sysdig] Fix 1.16 compatibility errors introduced in v1.4.19 (h…
Browse files Browse the repository at this point in the history
…elm#18230)

* Revert "[stable/sysdig] Fixes compatibility with 1.16 (helm#17538)"

This reverts commit d1811c2.

Signed-off-by: Néstor Salceda <nestor.salceda@sysdig.com>

* Add selector section needed for the version upgrade

Signed-off-by: Néstor Salceda <nestor.salceda@sysdig.com>

* Update Chart metadata and CHANGELOG

Signed-off-by: Néstor Salceda <nestor.salceda@sysdig.com>

* We support Kubernetes since 1.9+, with beta APIs enabled

Signed-off-by: Néstor Salceda <nestor.salceda@sysdig.com>
  • Loading branch information
Néstor Salceda authored and Ciprian Hacman committed Dec 5, 2019
1 parent 8437fe1 commit db725aa
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 15 deletions.
6 changes: 6 additions & 0 deletions stable/sysdig/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
This file documents all notable changes to Sysdig Helm Chart. The release
numbering uses [semantic versioning](http://semver.org).

## v1.4.20

### Minor changes

* Fixes compatibility errors introduced in v1.4.19.

## v1.4.19

### Minor changes
Expand Down
2 changes: 1 addition & 1 deletion stable/sysdig/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: sysdig
version: 1.4.19
version: 1.4.20
appVersion: 0.92.3
description: Sysdig Monitor and Secure agent
keywords:
Expand Down
2 changes: 1 addition & 1 deletion stable/sysdig/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This chart adds the Sysdig agent for [Sysdig Monitor](https://sysdig.com/product

## Prerequisites

- Kubernetes 1.2+ with Beta APIs enabled
- Kubernetes 1.9+ with Beta APIs enabled

## Installing the Chart

Expand Down
11 changes: 0 additions & 11 deletions stable/sysdig/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,3 @@ Also, we can't use a single if because lazy evaluation is not an option
{{- printf "%s/%s:%s" $registryName $repositoryName $tag -}}
{{- end -}}
{{- end -}}

{{/*
Return the apiVersion of daemonset.
*/}}
{{- define "daemonset.apiVersion" -}}
{{- if semverCompare "<1.14-0" .Capabilities.KubeVersion.GitVersion -}}
{{- print "extensions/v1beta1" -}}
{{- else if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
{{- print "apps/v1" -}}
{{- end -}}
{{- end -}}
6 changes: 4 additions & 2 deletions stable/sysdig/templates/daemonset.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if .Values.sysdig.accessKey }}
apiVersion: {{ template "daemonset.apiVersion" . }}
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: {{ template "sysdig.fullname" . }}
Expand All @@ -9,12 +9,14 @@ metadata:
release: "{{ .Release.Name }}"
heritage: "{{ .Release.Service }}"
spec:
selector:
matchLabels:
app: {{ template "sysdig.fullname" .}}
template:
metadata:
name: {{ template "sysdig.fullname" .}}
labels:
app: {{ template "sysdig.fullname" .}}
role: monitoring
spec:
serviceAccountName: {{ template "sysdig.serviceAccountName" .}}
{{- if .Values.priorityClassName }}
Expand Down

0 comments on commit db725aa

Please sign in to comment.