Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBEAP-24958 Removing Reset test for Configuration => Interface #32

Merged
merged 1 commit into from
Jun 13, 2023
Merged

JBEAP-24958 Removing Reset test for Configuration => Interface #32

merged 1 commit into from
Jun 13, 2023

Conversation

mchoma
Copy link
Contributor

@mchoma mchoma commented Jun 9, 2023

No description provided.

@mchoma
Copy link
Contributor Author

mchoma commented Jun 9, 2023

@spriadka @kstekovi Please review

@mchoma
Copy link
Contributor Author

mchoma commented Jun 9, 2023

Local run with changes

  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        1                                                                                │
  │ Passing:      1                                                                                │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        false                                                                            │
  │ Duration:     12 seconds                                                                       │
  │ Spec Ran:     test-configuration-interface.cy.ts                                               │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


====================================================================================================

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  test-configuration-interface.cy.ts       00:12        1        1        -        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        00:12        1        1        -        -        -

mchoma
mchoma commented Jun 12, 2023
View reviewed changes
packages/testsuite/cypress/e2e/interface/test-configuration-interface.cy.ts

it("Reset", () => {
cy.navigateTo(managementEndpoint, "interface;name=" + interfaceToEdit.name);
cy.resetForm(configurationFormId, managementEndpoint, address);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively this line can be written to expect current warning, but don't know how to write that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the test for now. We'll update this method in scope of #44.

@OndrejKotek
Copy link
Contributor

@mchoma Can you update the description of the PR and commit to be more descriptive please? Something like "JBEAP-24958 Removing Reset test for Configuration => Interface" could work.

@mchoma mchoma changed the title JBEAP-24958 Adjust test to new findings JBEAP-24958 Removing Reset test for Configuration => Interface Jun 13, 2023
@mchoma
Copy link
Contributor Author

mchoma commented Jun 13, 2023 •
edited
Loading

Can you update the description of the PR and commit?

Done

@OndrejKotek OndrejKotek assigned OndrejKotek and unassigned spriadka Jun 13, 2023
@OndrejKotek OndrejKotek mentioned this pull request Jun 13, 2023
Closed
2 tasks
@OndrejKotek OndrejKotek merged commit 58d596f into hal:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OndrejKotek OndrejKotek OndrejKotek left review comments

Assignees

@OndrejKotek OndrejKotek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchoma @OndrejKotek @spriadka