WFCORE-3017: It's not possible to call Elytron credential-store :add-… #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@honza-kasik any objection? |
|
LGTM, thanks! |
rhatlapa
requested changes
Jul 19, 2017
| result.assertDefinedValue(); | ||
| List<String> servers = result.stringListValue(); | ||
|
|
||
| List<String> startedServers = new ArrayList<String>(); |
There was a problem hiding this comment.
Creaper has methods like org.wildfly.extras.creaper.core.online.operations.admin.DomainAdministration#allRunningServers(java.lang.String), why don't you make use of it?
There was a problem hiding this comment.
I wasn't aware of that method. Thx.
|
It is better to reuse and not to write new one => please reuse existing code from creaper instead of writing new methods. |
…alias via profile in domain any more.
|
Amended. |
spriadka
pushed a commit
to spriadka/testsuite
that referenced
this pull request
Jul 31, 2017
WFCORE-3017: It's not possible to call Elytron credential-store :add-… initial commit added tests for WebServices -> EndpointConfiguration added tests for duplicate resource creation added tests for property manipulation in WebServices -> Endpoint config added tests for client configuration added pre handler tests for client configuration added tests for edit protocol bindings added tests for handlerchain handlers in client config and endpoint config minor refactoring final changes before rebase & PR changed after PR review, before WebServicesTestCaseAbstract refactor finished refactoring, before merging moved create* methods from WebServicesTestCaseAbstract to page object, removed restart of administration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alias via profile in domain any more.