Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements? #39

Open
andreasvlachos opened this issue Apr 10, 2019 · 9 comments
Open

requirements? #39

andreasvlachos opened this issue Apr 10, 2019 · 9 comments

Comments

@andreasvlachos
Copy link

Greetings,

Thanks for putting this together, it looks very exciting! I had some trouble figuring out the requirements, could you maybe put a file for them to make sure I am not missing something obvious? Or are they stated somewhere?

Best,
Andreas
@hal3
Copy link
Owner

hal3 commented Apr 10, 2019

it should only require pytorch unless i forgot something. what errors are you getting?

@xkianteb
Copy link
Collaborator

xkianteb commented Apr 10, 2019 via email

@andreasvlachos
Copy link
Author

Hi, thanks for the quick response. I am using the master branch. Which python version should I use? I think the errors might be related to that.

@hal3
Copy link
Owner

hal3 commented Apr 11, 2019 via email

@andreasvlachos
Copy link
Author

Hi, I built a conda environment with these (might be good to specify the pytorch version as the default download is 1.0), run:
python setup.py install, installed progressbar with conda install progressbar2 (otherwise it wants to downgrade to python2) and when running python test_randomly.py I get:
ImportError: No module named 'macarico.lts'
I checked and I can import macarico fine from the terminal.
What am I missing? Thanks!

@bgalbraith
Copy link

Hi @andreasvlachos! I've been working through the codebase as well and I've run into some similar issues (conda environment, python 3.7, pytorch 1.0). I've been going through the exercise of refactoring the code for this environment as well as updating the old tests that were from an earlier iteration of the code and now break if you try to run them as is.

One thing I found that helps is to install the project into your conda environment by running pip install -e . This seems to clear up the macarico import errors.

Cheers,
Byron

@bgalbraith
Copy link

Also, test_randomly.py won't work as it is trying to import modules in the macarico/data package which don't exist: synthetic and types. All folders named data are ignored by a rule in .gitignore, so maybe these exit on @hal3's local machine but never got pushed to the repo ;)

A test that should run as is is test_concentration.py

@andreasvlachos
Copy link
Author

@bgalbraith thanks for the tips. Got snowed under other work, but I will get back on this as I am very interested.

@xkianteb
Copy link
Collaborator

xkianteb commented May 9, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bgalbraith @hal3 @andreasvlachos @xkianteb