Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adams2019] Restructure autoscheduler + add timer #5654

Merged
merged 17 commits into from
Feb 2, 2021

Conversation

rootjalex
Copy link
Member

@rootjalex rootjalex commented Jan 20, 2021

Adds caching of features and schedule enumerations to the adams2019 autoscheduler. Backported from @aekul 's autoscheduler work.

On my machine, I see a x2 speedup on the time needed to autoschedule lens blur and local laplacian, about a x1.5 speedup for resnet50, and anywhere between x1-1.5 for other pipelines (caching is only useful for larger pipelines, it has little to no effect on smaller pipelines).
This PR is now just a restructuring + addition of a timer to the adams2019 autoscheduler, to allow for the addition of caching.

@rootjalex rootjalex added the autoscheduler Related to one or more of the Autoschedulers label Jan 20, 2021
@rootjalex rootjalex linked an issue Jan 20, 2021 that may be closed by this pull request
@rootjalex rootjalex requested a review from aekul January 20, 2021 16:36
@steven-johnson
Copy link
Contributor

Buildbots are green (ignoring the buildbot-beta); looks ready to be reviewed.

@abadams
Copy link
Member

abadams commented Feb 1, 2021

This is large and hard to review. It looks like there are two things here - a refactor of the autoscheduler into more files, and adding caching. Is it possible to disentangle them into separate PRs (e.g. by deleting everything caching related from this PR, and then reintroducing it in another?). I can't tell what's moved code and what's new.

@rootjalex rootjalex changed the title [adams2019] Add caching to autoscheduler (addresses #5603) [adams2019] Restructure autoscheduler + add timer Feb 1, 2021
@rootjalex
Copy link
Member Author

@abadams This PR should now just be restructuring (+ the addition of the timer, but I can remove that and put it in the caching PR if necessary).

@abadams
Copy link
Member

abadams commented Feb 2, 2021

lgtm with one final suggested change.

@abadams
Copy link
Member

abadams commented Feb 2, 2021

Thanks, you are good to merge once the bots are all green.

@rootjalex
Copy link
Member Author

Failures look unrelated to the autoscheduler, @steven-johnson can you confirm?

@steven-johnson
Copy link
Contributor

Failures are unrelated, OK to land

@steven-johnson steven-johnson merged commit 99c5583 into master Feb 2, 2021
@steven-johnson steven-johnson deleted the rootjalex/add_autosched_caching branch February 2, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoscheduler Related to one or more of the Autoschedulers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants