Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS RangedSlider in iOS page/formsheets, and added active color support for iOS #168

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Tommigun1980
Copy link

@Tommigun1980 Tommigun1980 commented Aug 22, 2020

This fixes #167, by stopping event propagation when slider is dragged.

This also implements #150, by adding ActiveColor support for iOS.
Screenshot 2020-08-23 at 1 34 23

@Tommigun1980
Copy link
Author

The CI issues seem to have to do with the CI system and not this PR.

@Tommigun1980 Tommigun1980 changed the title Stop event propagation on iOS when slider is dragged Stop event propagation on iOS when slider is dragged + active color support for iOS Aug 22, 2020
@Tommigun1980
Copy link
Author

Please note that if ActiveColor is not set the tint will default to system tint. To make it white, one has to set ActiveColor to white.

@Tommigun1980 Tommigun1980 changed the title Stop event propagation on iOS when slider is dragged + active color support for iOS Fix iOS RangedSlider in iOS page/formsheets, and added active color support for iOS Aug 22, 2020
@Tommigun1980
Copy link
Author

Hi.

Any chance these fixes and enhancements could be accepted and a new version be released?

Thanks.

@halkar
Copy link
Owner

halkar commented Sep 7, 2020

@Tommigun1980

  1. The build is broken (just comment sonarqube for now).
  2. You are changing the default behaviour. If you want to change it you can use the same Material UI flag.
  3. Don't rename properties just because you don't like the original naming convention.

@Tommigun1980
Copy link
Author

@Tommigun1980

  1. The build is broken (just comment sonarqube for now).
  2. You are changing the default behaviour. If you want to change it you can use the same Material UI flag.
  3. Don't rename properties just because you don't like the original naming convention.

Hi.

  1. What do you mean with "just comment sonarcube"? The build seems to fail from some CI things outside of this pull request.
  2. What behaviour are you referring to, the default color? In that case shouldn't the default behaviour be what is native behaviour? Also what do you mean with the same Material UI flag - do you want the colouring behaviour to be enabled via it?
  3. Oh sorry, that was unintentional, I think it was one of those VS auto-fix things. I can put it back.

@halkar
Copy link
Owner

halkar commented Sep 7, 2020

  1. Sorry, I was referring to lines https://github.com/halkar/xamarin-range-slider/blob/master/build.cake#L54 and https://github.com/halkar/xamarin-range-slider/blob/master/build.cake#L56
  2. Yes, I understand that the current behaviour maybe not perfect but existing programs may rely on it. Yes, I was talking about the old Material UI flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form/PageSheet on iOS doesn't work that nicely
2 participants