-
Notifications
You must be signed in to change notification settings - Fork 482
fix: build:packages
script not running on Windows
#642
Conversation
@Simple-Stark is attempting to deploy a commit to the halo-dev Team on Vercel. A member of the Team first needs to authorize it. |
Deployment failed with the following error:
|
@Simple-Stark Hello,建议修改 package.json 的 scripts 以兼容各个平台,使用如下的修改方式理论上是可行的: - "build:packages": "pnpm --filter './packages/**' build",
+ "build:packages": "pnpm --filter \"./packages/**\" build", |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
23c1127
to
0f0062a
Compare
0f0062a
to
e419ddc
Compare
/reopen |
@JohnNiang: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/remove-kind documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Linux environment:
╭─ ~/workspaces/halo-dev/halo-admin on fix_2568 ································································· ✘ INT
╰─❯ pnpm build:packages
> @halo-dev/console@0.0.0 build:packages /home/johnniang/workspaces/halo-dev/halo-admin
> pnpm --filter "./packages/**" build
Scope: 2 of 3 workspace projects
packages/components build$ vite build
[2 lines collapsed]
│ "resolveDirective" is imported from external module "vue" but never used in "~icons/ri/dashboard-3-line", "~icons/ri/arrow-l
│ ✓ 181 modules transformed.
│ rendering chunks...
│ dist/style.css 43.28 KiB / gzip: 6.84 KiB
│ dist/halo-components.es.js 520.89 KiB / gzip: 141.07 KiB
│ dist/halo-components.es.js.map 1553.80 KiB
│ dist/halo-components.iife.js 397.02 KiB / gzip: 125.40 KiB
│ dist/halo-components.iife.js.map 1518.68 KiB
│ [vite:dts] Start generate declaration files...
│ [vite:dts] Declaration files built in 3032ms.
└─ Done in 7.9s
packages/shared build$ vite build
[1 lines collapsed]
│ transforming...
│ ✓ 66 modules transformed.
│ rendering chunks...
│ dist/style.css 0.70 KiB / gzip: 0.33 KiB
│ dist/halo-console-shared.es.js 42.50 KiB / gzip: 14.36 KiB
│ dist/halo-console-shared.es.js.map 108.21 KiB
│ dist/halo-console-shared.iife.js 33.25 KiB / gzip: 12.95 KiB
│ dist/halo-console-shared.iife.js.map 105.84 KiB
│ [vite:dts] Start generate declaration files...
│ [vite:dts] Declaration files built in 2009ms.
└─ Done in 4.2s
/lgtm
/retitle Fix the problem of running "pnpm build:packages" in Windows environment |
/retitle fix: |
build:packages
script not running on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @halo-dev/sig-halo-console
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#642) #### What type of PR is this? /kind documentation #### What this PR does / why we need it: 修复在 Windows 平台下无法正常运行 `build:packages` 等脚本的问题。 #### Which issue(s) this PR fixes: Fixes halo-dev#2568 #### Does this PR introduce a user-facing change? ```release-note NONE ```
What type of PR is this?
/kind documentation
What this PR does / why we need it:
修复在 Windows 平台下无法正常运行
build:packages
等脚本的问题。Which issue(s) this PR fixes:
Fixes halo-dev/halo#2568
Does this PR introduce a user-facing change?