Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

fix: build:packages script not running on Windows #642

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

Simple-Stark
Copy link
Contributor

@Simple-Stark Simple-Stark commented Oct 13, 2022

What type of PR is this?

/kind documentation

What this PR does / why we need it:

修复在 Windows 平台下无法正常运行 build:packages 等脚本的问题。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2568

Does this PR introduce a user-facing change?

NONE

@f2c-ci-robot f2c-ci-robot bot added kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 13, 2022
@CLAassistant
Copy link

CLAassistant commented Oct 13, 2022

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Oct 13, 2022

@Simple-Stark is attempting to deploy a commit to the halo-dev Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 13, 2022

Deployment failed with the following error:

Creating the Deployment Timed Out.

@ruibaby
Copy link
Member

ruibaby commented Oct 13, 2022

@Simple-Stark Hello,建议修改 package.json 的 scripts 以兼容各个平台,使用如下的修改方式理论上是可行的:

- "build:packages": "pnpm --filter './packages/**' build",
+ "build:packages": "pnpm --filter \"./packages/**\" build",

@vercel
Copy link

vercel bot commented Oct 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
halo-admin-next ✅ Ready (Inspect) Visit Preview Oct 14, 2022 at 5:50AM (UTC)
halo-admin-ui ✅ Ready (Inspect) Visit Preview Oct 14, 2022 at 5:50AM (UTC)

@JohnNiang
Copy link
Member

/reopen

@f2c-ci-robot f2c-ci-robot bot reopened this Oct 14, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 14, 2022

@JohnNiang: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Simple-Stark
Copy link
Contributor Author

kind/documentation 标签是否可以去掉了,这可能属于kind/bug

@ruibaby
Copy link
Member

ruibaby commented Oct 14, 2022

kind/documentation 标签是否可以去掉了,这可能属于kind/bug

/remove-kind documentation
/kind improvement

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. and removed kind/documentation Categorizes issue or PR as related to documentation. labels Oct 14, 2022
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Linux environment:

╭─   ~/workspaces/halo-dev/halo-admin on   fix_2568 ································································· ✘ INT
╰─❯ pnpm build:packages

> @halo-dev/console@0.0.0 build:packages /home/johnniang/workspaces/halo-dev/halo-admin
> pnpm --filter "./packages/**" build

Scope: 2 of 3 workspace projects
packages/components build$ vite build
[2 lines collapsed]
│ "resolveDirective" is imported from external module "vue" but never used in "~icons/ri/dashboard-3-line", "~icons/ri/arrow-l
│ ✓ 181 modules transformed.
│ rendering chunks...
│ dist/style.css               43.28 KiB / gzip: 6.84 KiB
│ dist/halo-components.es.js   520.89 KiB / gzip: 141.07 KiB
│ dist/halo-components.es.js.map 1553.80 KiB
│ dist/halo-components.iife.js   397.02 KiB / gzip: 125.40 KiB
│ dist/halo-components.iife.js.map 1518.68 KiB
│ [vite:dts] Start generate declaration files...
│ [vite:dts] Declaration files built in 3032ms.
└─ Done in 7.9s
packages/shared build$ vite build
[1 lines collapsed]
│ transforming...
│ ✓ 66 modules transformed.
│ rendering chunks...
│ dist/style.css                   0.70 KiB / gzip: 0.33 KiB
│ dist/halo-console-shared.es.js   42.50 KiB / gzip: 14.36 KiB
│ dist/halo-console-shared.es.js.map 108.21 KiB
│ dist/halo-console-shared.iife.js   33.25 KiB / gzip: 12.95 KiB
│ dist/halo-console-shared.iife.js.map 105.84 KiB
│ [vite:dts] Start generate declaration files...
│ [vite:dts] Declaration files built in 2009ms.
└─ Done in 4.2s

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@JohnNiang
Copy link
Member

/retitle Fix the problem of running "pnpm build:packages" in Windows environment

@f2c-ci-robot f2c-ci-robot bot changed the title fix(README.md): windows开发环境运行命令提示 Fix the problem of running "pnpm build:packages" in Windows environment Oct 14, 2022
@ruibaby
Copy link
Member

ruibaby commented Oct 14, 2022

/retitle fix: build:packages script not running on Windows

@f2c-ci-robot f2c-ci-robot bot changed the title Fix the problem of running "pnpm build:packages" in Windows environment fix: build:packages script not running on Windows Oct 14, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cc @halo-dev/sig-halo-console

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 279dc59 into halo-dev:main Oct 14, 2022
@Simple-Stark Simple-Stark deleted the fix_2568 branch October 14, 2022 05:59
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…#642)

#### What type of PR is this?

/kind documentation

#### What this PR does / why we need it:

修复在 Windows 平台下无法正常运行 `build:packages` 等脚本的问题。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2568

#### Does this PR introduce a user-facing change?

```release-note
NONE
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console 文档补充
5 participants