Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

优化 Docker 容器创建时的配置方式 #163

Closed
ruibaby opened this issue Jan 3, 2023 · 1 comment · Fixed by #164
Closed

优化 Docker 容器创建时的配置方式 #163

ruibaby opened this issue Jan 3, 2023 · 1 comment · Fixed by #164
Assignees
@JohnNiang
Labels
kind/documentation Categorizes issue or PR as related to documentation. kind/improvement Categorizes issue or PR as related to a improvement.

Comments

@ruibaby
Copy link
Member

ruibaby commented Jan 3, 2023

现在 Halo 已经支持了通过参数来配置应用，请参考：halo-dev/halo#3098

期望文档也与这种方式保持一致。

/kind improvement
/kind documentation
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. kind/documentation Categorizes issue or PR as related to documentation. labels Jan 3, 2023
@JohnNiang
Copy link
Member

/assign

@JohnNiang JohnNiang mentioned this issue Jan 3, 2023
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Jan 4, 2023
@JohnNiang
Refine run methods with arguments instead of environments (#164)
4634f74 
#### What this PR does/Why we need it?

1. Refine Docker run command and Docker compose file with arguments instead of environments for Halo 2.1 and 2.2.0-SNAPSHOT.
2. Change environments description into arguments description.

#### Which issue(s) this PR fixes:

Fix #163

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnNiang JohnNiang

Labels
kind/documentation Categorizes issue or PR as related to documentation. kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine run methods with arguments instead of environments JohnNiang/docs
2 participants
@JohnNiang @ruibaby