Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add healthcheck for halo in compose #189

Merged
merged 3 commits into from
Feb 27, 2023
Merged

docs: add healthcheck for halo in compose #189

merged 3 commits into from
Feb 27, 2023

Conversation

wan92hen
Copy link
Collaborator

@wan92hen wan92hen commented Feb 27, 2023 •
edited
Loading

在 Docker Compose 文件中，使用 /actuator/health/readiness 接口为 Halo 服务增加健康检查。

docs: add healthcheck for halo in compose

@vercel
Copy link

vercel bot commented Feb 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
halo-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 3:57AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 27, 2023
JohnNiang
JohnNiang reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Halo 默认暴露了两个健康检查端口：

  1. http://localhost:8090/actuator/health/liveness
  2. http://localhost:8090/actuator/health/readiness

推荐使用以上两个接口测试 Halo 的健康情况。

不过需要注意的是，该功能是 2.2.0 才暴露的。所以建议同时修改一下 2.2 的文档。

@wan92hen
Copy link
Collaborator Author

wan92hen commented Feb 27, 2023 •
edited
Loading

Halo 默认暴露了两个健康检查端口：

  1. http://localhost:8090/actuator/health/liveness
  2. http://localhost:8090/actuator/health/readiness

推荐使用以上两个接口测试 Halo 的健康情况。

不过需要注意的是，该功能是 2.2.0 才暴露的。所以建议同时修改一下 2.2 的文档。

Compose 中只有一个 health_check，没有区分 liveness 和 readiness，这里直接使用 readiness 接口如何？

@JohnNiang
Copy link
Member

Compose 中只有一个 health_check，没有区分 liveness 和 readiness，这里直接使用 readiness 接口如何？

可以的。

@wan92hen
Copy link
Collaborator Author

Compose 中只有一个 health_check，没有区分 liveness 和 readiness，这里直接使用 readiness 接口如何？

可以的。

updated

ruibaby
ruibaby approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
guqing
guqing reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit f6e0ae6 into halo-dev:main Feb 27, 2023
@ruibaby ruibaby mentioned this pull request Feb 28, 2023
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Mar 1, 2023
@ruibaby
fix: incorrect hightlight number of docker compose example code block (…
29a7cc4 
…#195)

/kind documentation

修复由 #189 导致的 Docker Compose 代码块高亮行错误的问题。

before:

<img width="727" alt="image" src="https://user-images.githubusercontent.com/21301288/221819214-fd261a4a-c6bf-4228-8377-bbb3a7aebb55.png">

after:

<img width="917" alt="image" src="https://user-images.githubusercontent.com/21301288/221819329-5087b143-e93c-4eff-a101-2d003c8f2e2a.png">

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang left review comments

@guqing guqing guqing left review comments

@ruibaby ruibaby ruibaby approved these changes

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wan92hen @JohnNiang @ruibaby @guqing