Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: refine documentation of installation #215

Merged
merged 1 commit into from
May 8, 2023
Merged

docs: refine documentation of installation #215

merged 1 commit into from
May 8, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 4, 2023 •
edited
Loading

优化安装文档。

  1. 优化安装完成之后的提示。
  2. 优化 Docker 启动参数的描述。
  3. Docker 的数据库配置参数添加 MariaDB 的说明。
  4. 移动反向代理方式的顺序。

/kind documentation

None

@ruibaby
docs: refine documentation of installation
924da72 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@vercel
Copy link

vercel bot commented May 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
halo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 3:37am

@f2c-ci-robot f2c-ci-robot bot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 4, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang May 4, 2023 03:35
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 4, 2023
guqing
guqing reviewed May 4, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
@ruibaby
Copy link
Member Author

ruibaby commented May 7, 2023

cc @halo-dev/sig-docs

JohnNiang
JohnNiang approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 9daf914 into halo-dev:main May 8, 2023
@ruibaby ruibaby deleted the docs/update-installation branch October 23, 2023 09:19
@ruibaby ruibaby mentioned this pull request Dec 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruibaby @JohnNiang @guqing