Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add configuration examples for the Windows platform in the plugin-related documents #219

Merged
merged 3 commits into from
May 26, 2023
Merged

docs: add configuration examples for the Windows platform in the plugin-related documents #219

merged 3 commits into from
May 26, 2023

Conversation

Simple-Stark
Copy link
Contributor

@Simple-Stark Simple-Stark commented May 23, 2023 •
edited by ruibaby
Loading

Halo 插件开发 Windows 环境下插件绝对路径的补充

Ref #218

/kind documentation

None

@vercel
Copy link

vercel bot commented May 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
halo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 9:52am

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 23, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby May 23, 2023 05:36
@JohnNiang
Copy link
Member

/cc @halo-dev/sig-docs

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 24, 2023

@JohnNiang: GitHub didn't allow me to request PR reviews from the following users: halo-dev/sig-docs.

Note that only halo-dev members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @halo-dev/sig-docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 26, 2023
ruibaby
ruibaby requested changes May 26, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献，这里有一些改动建议。

另外，除了 version-2.5 的文档需要改，对应的 docs 目录下的文件也需要修改。

versioned_docs/version-2.5/developer-guide/plugin/runtime-mode.md Show resolved Hide resolved
@Simple-Stark
Copy link
Contributor Author

Simple-Stark commented May 26, 2023 •
edited
Loading

@ruibaby 已修改

@ruibaby ruibaby changed the title refactor(插件开发): Halo 插件开发windos环境下插件绝对路径的补充 docs: add configuration examples for the Windows platform in the plugin-related documents May 26, 2023
ruibaby
ruibaby reviewed May 26, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
JohnNiang
JohnNiang approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 4b934c0 into halo-dev:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@ruibaby ruibaby ruibaby approved these changes

@guqing guqing Awaiting requested review from guqing

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Simple-Stark @JohnNiang @ruibaby