Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

fix: the problem of adding link pop-up box showing scroll bar #5

Merged
merged 1 commit into from
Jul 4, 2022
Merged

fix: the problem of adding link pop-up box showing scroll bar #5

merged 1 commit into from
Jul 4, 2022

Conversation

wxyShine
Copy link
Contributor

@wxyShine wxyShine commented Jul 4, 2022

Fix halo-dev/halo#2201

What type of PR is this?

/kind bug

Does this PR introduce a user-facing change?

修复编辑器的滑动条会与链接面板有重叠的问题

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 4, 2022
@wxyShine
Copy link
Contributor Author

wxyShine commented Jul 4, 2022

修改之后测试图

@JohnNiang
Copy link
Member

JohnNiang commented Jul 4, 2022

Nice work!

不过建议对当前这个 PR 留下一个 Release Note,可以按照以下格式修改 PR 描述:

    #### Does this PR introduce a user-facing change?
    
    <!--
    如果当前 Pull Request 的修改不会造成用户侧的任何变更,在 `release-note` 代码块儿中填写 `NONE`。
    否则请填写用户侧能够理解的 Release Note。如果当前 Pull Request 包含破坏性更新(Break Change),
    Release Note 需要以 `action required` 开头。
    If no, just write "NONE" in the release-note block below.
    If yes, a release note is required:
    Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
    -->
    
    ```release-note
    ```

可参考:https://raw.githubusercontent.com/halo-dev/halo/master/.github/pull_request_template.md

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 4, 2022
@ruibaby
Copy link
Member

ruibaby commented Jul 4, 2022

/retitle fix: the problem of adding link pop-up box showing scroll bar

@f2c-ci-robot f2c-ci-robot bot changed the title 🐛 Solve the problem of scroll bar blocking pop-up box fix: the problem of adding link pop-up box showing scroll bar Jul 4, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 4, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 4, 2022
@ruibaby ruibaby merged commit 6da1270 into halo-dev:master Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

编辑文章的时候,滑动条会与链接面板有重叠。
3 participants