-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: optimizing regex pettern for html meta matching #4235
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4235 +/- ##
=========================================
Coverage 60.18% 60.18%
+ Complexity 2414 2413 -1
=========================================
Files 366 366
Lines 12586 12586
Branches 906 905 -1
=========================================
Hits 7575 7575
Misses 4571 4571
Partials 440 440
|
/cherry-pick release-2.7.0 |
@guqing: once the present PR merges, I will cherry-pick it on top of release-2.7.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
似乎缺少对应的测试用例。
添加了对应正则的测试用例 |
/cc @halo-dev/sig-halo |
@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-dev/sig-halo. Note that only halo-dev members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@guqing: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind improvement
/area core
/milestone 2.8.x
What this PR does / why we need it:
优化去除 Html Meta 重复标签的正则表达式
see #4234 for more details.
Which issue(s) this PR fixes:
Fixes #4234
Does this PR introduce a user-facing change?