Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimizing regex pettern for html meta matching #4235

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 16, 2023

What type of PR is this?

/kind improvement
/area core
/milestone 2.8.x

What this PR does / why we need it:

优化去除 Html Meta 重复标签的正则表达式

see #4234 for more details.

Which issue(s) this PR fixes:

Fixes #4234

Does this PR introduce a user-facing change?

优化去除 Html Meta 重复标签的正则表达式

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 16, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.8.x milestone Jul 16, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #4235 (d26e288) into main (1dc2f6f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #4235   +/-   ##
=========================================
  Coverage     60.18%   60.18%           
+ Complexity     2414     2413    -1     
=========================================
  Files           366      366           
  Lines         12586    12586           
  Branches        906      905    -1     
=========================================
  Hits           7575     7575           
  Misses         4571     4571           
  Partials        440      440           
Impacted Files Coverage Δ
...o/app/theme/dialect/DuplicateMetaTagProcessor.java 100.00% <100.00%> (ø)

@guqing
Copy link
Member Author

guqing commented Jul 17, 2023

/cherry-pick release-2.7.0

@halo-dev-bot
Copy link
Collaborator

@guqing: once the present PR merges, I will cherry-pick it on top of release-2.7.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.7.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

似乎缺少对应的测试用例。

@guqing
Copy link
Member Author

guqing commented Jul 19, 2023

似乎缺少对应的测试用例。

添加了对应正则的测试用例

@guqing
Copy link
Member Author

guqing commented Jul 20, 2023

/cc @halo-dev/sig-halo

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 20, 2023

@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-dev/sig-halo.

Note that only halo-dev members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @halo-dev/sig-halo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 5eb9b68 into halo-dev:main Jul 20, 2023
2 checks passed
@halo-dev-bot
Copy link
Collaborator

@guqing: cannot checkout release-2.7.0: error checking out release-2.7.0: exit status 1. output: error: pathspec 'release-2.7.0' did not match any file(s) known to git

In response to this:

/cherry-pick release-2.7.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guqing guqing deleted the refactor/4234 branch July 20, 2023 08:57
@ruibaby ruibaby modified the milestones: 2.8.x, 2.8.0 Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

重复 HTML Meta 标签没有被完全处理
4 participants