-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor the repeater component using the schema approach #4702
Conversation
/area console |
Codecov Report
@@ Coverage Diff @@
## main #4702 +/- ##
=========================================
Coverage 61.58% 61.59%
Complexity 2797 2797
=========================================
Files 403 403
Lines 14722 14723 +1
Branches 1023 1023
=========================================
+ Hits 9067 9068 +1
Misses 5163 5163
Partials 492 492 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
What this PR does / why we need it:
对 Formkit Repeater 组件使用 schema 的方式进行重构,重构后的 Repeater 组件将支持条件判断,按照下述方式定义即可。
同时额外增加了对
addLabel
、addButton
、upControl
、downControl
、insertControl
、removeControl
属性的支持。How to test it?
Repeater
组件可否正常使用。Repeater
条件判断功能进行测试。Which issue(s) this PR fixes:
Fixes #4603
Does this PR introduce a user-facing change?