-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: using index mechanisms to optimize comment queries #5453
Conversation
/cc @ruibaby 需要重新修改一下评论列表的筛选条件和排序的字段 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5453 +/- ##
============================================
- Coverage 56.91% 56.81% -0.10%
- Complexity 3319 3321 +2
============================================
Files 587 589 +2
Lines 18968 19082 +114
Branches 1401 1365 -36
============================================
+ Hits 10795 10841 +46
- Misses 7594 7668 +74
+ Partials 579 573 -6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Wang <i@ryanc.cc>
已修改。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area core
/milestone 2.14.x
What this PR does / why we need it:
使用索引机制优化评论数据查询以提高效率
Resolves #5435
how to test it?
Does this PR introduce a user-facing change?