Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using index mechanisms to optimize comment queries #5453

Merged
merged 6 commits into from
Mar 8, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Mar 6, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.14.x

What this PR does / why we need it:

使用索引机制优化评论数据查询以提高效率

Resolves #5435

how to test it?

  • 测试 console 评论列表和筛选条件是否正确
  • 测试主题端评论显示是否正确

Does this PR introduce a user-facing change?

使用索引机制优化评论数据查询以提高效率

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 6, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.x milestone Mar 6, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Mar 6, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and minliacom March 6, 2024 07:57
@guqing
Copy link
Member Author

guqing commented Mar 6, 2024

/cc @ruibaby 需要重新修改一下评论列表的筛选条件和排序的字段

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 91.45299% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 56.81%. Comparing base (5fdf6c0) to head (c447512).
Report is 45 commits behind head on main.

Files Patch % Lines
...ava/run/halo/app/content/comment/CommentQuery.java 57.14% 4 Missing and 2 partials ⚠️
...a/run/halo/app/core/extension/content/Comment.java 0.00% 2 Missing ⚠️
...halo/app/theme/endpoint/CommentFinderEndpoint.java 66.66% 0 Missing and 1 partial ⚠️
...me/finders/impl/CommentPublicQueryServiceImpl.java 97.22% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5453      +/-   ##
============================================
- Coverage     56.91%   56.81%   -0.10%     
- Complexity     3319     3321       +2     
============================================
  Files           587      589       +2     
  Lines         18968    19082     +114     
  Branches       1401     1365      -36     
============================================
+ Hits          10795    10841      +46     
- Misses         7594     7668      +74     
+ Partials        579      573       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member

ruibaby commented Mar 7, 2024

/cc @ruibaby 需要重新修改一下评论列表的筛选条件和排序的字段

已修改。

@guqing guqing marked this pull request as ready for review March 8, 2024 04:47
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
Copy link

f2c-ci-robot bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 20d80f8 into halo-dev:main Mar 8, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 11, 2024
@guqing guqing deleted the refactor/indexed-comment branch March 13, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

关于评论显示的建议
3 participants