Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that some plugins could not be used after upgrading dependent plugin #5855

Merged

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area plugin
/area core

What this PR does / why we need it:

This PR resolves the problem that some plugins could not be used after upgrading dependent plugin.

Which issue(s) this PR fixes:

Fixes #5615

Special notes for your reviewer:

  1. Install plugin app-store
  2. Install plugin backup and activate it
  3. Disable plugin app-store
  4. Check the features of plugin backup
  5. Enable plugin app-store
  6. Check the features of plugin backup
  7. Upgrade plugin app-store with the any versions
  8. Check the features of plugin backup

Does this PR introduce a user-facing change?

修复因升级应用市场插件导致部分插件意外停止的问题

@JohnNiang JohnNiang added kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider labels May 4, 2024
@JohnNiang JohnNiang force-pushed the bug/plugin-dependencies-not-started branch from efbbea1 to ccf5f9c Compare May 4, 2024 15:06
Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.54%. Comparing base (5fdf6c0) to head (ccf5f9c).
Report is 159 commits behind head on main.

❗ Current head ccf5f9c differs from pull request most recent head dc2745e. Consider uploading reports for the commit dc2745e to get more accurate results

Files Patch % Lines
...pp/core/extension/reconciler/PluginReconciler.java 88.88% 0 Missing and 1 partial ⚠️
...in/java/run/halo/app/plugin/HaloPluginManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5855      +/-   ##
============================================
- Coverage     56.91%   56.54%   -0.37%     
- Complexity     3319     3443     +124     
============================================
  Files           587      612      +25     
  Lines         18968    20337    +1369     
  Branches       1401     1396       -5     
============================================
+ Hits          10795    11500     +705     
- Misses         7594     8263     +669     
+ Partials        579      574       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2024
@ruibaby
Copy link
Member

ruibaby commented May 5, 2024

/cherrypick release-2.15

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.15 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang
Copy link
Member Author

/hold

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@JohnNiang JohnNiang force-pushed the bug/plugin-dependencies-not-started branch from ccf5f9c to 5b9130a Compare May 6, 2024 11:38
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@JohnNiang JohnNiang force-pushed the bug/plugin-dependencies-not-started branch from 5b9130a to dc2745e Compare May 6, 2024 11:40
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@JohnNiang
Copy link
Member Author

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@JohnNiang JohnNiang added this to the 2.16.x milestone May 6, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
Copy link

f2c-ci-robot bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit fe809c1 into halo-dev:main May 7, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #5865

In response to this:

/cherrypick release-2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request May 7, 2024
…ter upgrading dependent plugin (#5865)

This is an automated cherry-pick of #5855

/assign ruibaby

```release-note
修复因升级应用市场插件导致部分插件意外停止的问题
```
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

插件卸载后已经加载的插件类无法被 unload
4 participants