Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extension resources weren't deleted as expected on initialization #5859

Merged
merged 1 commit into from
May 6, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented May 6, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.16.x

What this PR does / why we need it:

修复初始化时未按预期删除自定义资源

Does this PR introduce a user-facing change?

修复初始化时未按预期删除自定义资源

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 6, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 6, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label May 6, 2024
@guqing
Copy link
Member Author

guqing commented May 6, 2024

/cherry-pick release-2.15

@halo-dev-bot
Copy link
Collaborator

@guqing: once the present PR merges, I will cherry-pick it on top of release-2.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby May 6, 2024 04:24
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.54%. Comparing base (5fdf6c0) to head (d12fd82).
Report is 158 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5859      +/-   ##
============================================
- Coverage     56.91%   56.54%   -0.37%     
- Complexity     3319     3444     +125     
============================================
  Files           587      612      +25     
  Lines         18968    20336    +1368     
  Branches       1401     1396       -5     
============================================
+ Hits          10795    11500     +705     
- Misses         7594     8262     +668     
+ Partials        579      574       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing changed the title fix: lower level roles not being hidden fix: extension resources weren't deleted as expected on initialization May 6, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@ruibaby
Copy link
Member

ruibaby commented May 6, 2024

/cherrypick release-2.15

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.15 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 9b3f00d into halo-dev:main May 6, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@guqing: new pull request created: #5860

In response to this:

/cherry-pick release-2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request May 6, 2024
…n initialization (#5860)

This is an automated cherry-pick of #5859

/assign guqing

```release-note
修复初始化时未按预期删除自定义资源
```
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 9, 2024
@guqing guqing deleted the fix/extension-initial branch May 23, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants