Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scheduled post publishing feature #5940

Merged
merged 3 commits into from
May 24, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented May 17, 2024

What type of PR is this?

/kind feature
/area core
/milestone 2.16.x

What this PR does / why we need it:

新增文章定时发布功能

Which issue(s) this PR fixes:

Fixes #4602

Does this PR introduce a user-facing change?

新增文章定时发布功能

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 17, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 17, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label May 17, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen May 17, 2024 08:12
@guqing
Copy link
Member Author

guqing commented May 17, 2024

@ruibaby 帮忙适配一下 Console 文章发布,添加定时发布选项并在文章列表条件过滤里加入”计划发布”或“定时发布”之类的筛选条件

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 56.79%. Comparing base (5fdf6c0) to head (579cc0a).
Report is 196 commits behind head on main.

Files Patch % Lines
.../app/core/extension/reconciler/PostReconciler.java 56.75% 10 Missing and 6 partials ⚠️
...un/halo/app/event/post/PostScheduledToPublish.java 0.00% 4 Missing ⚠️
...halo/app/core/extension/endpoint/PostEndpoint.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5940      +/-   ##
============================================
- Coverage     56.91%   56.79%   -0.12%     
- Complexity     3319     3503     +184     
============================================
  Files           587      613      +26     
  Lines         18968    20575    +1607     
  Branches       1401     1422      +21     
============================================
+ Hits          10795    11686     +891     
- Misses         7594     8308     +714     
- Partials        579      581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing force-pushed the feature/4602 branch 2 times, most recently from b2717c5 to 420b025 Compare May 21, 2024 07:44
@guqing guqing marked this pull request as ready for review May 21, 2024 08:48
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wzrove May 21, 2024 08:49
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 63.82979% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 56.74%. Comparing base (5fdf6c0) to head (7e80d7a).
Report is 199 commits behind head on main.

Files Patch % Lines
.../app/core/extension/reconciler/PostReconciler.java 56.75% 10 Missing and 6 partials ⚠️
...halo/app/core/extension/endpoint/PostEndpoint.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5940      +/-   ##
============================================
- Coverage     56.91%   56.74%   -0.18%     
- Complexity     3319     3491     +172     
============================================
  Files           587      611      +24     
  Lines         18968    20539    +1571     
  Branches       1401     1421      +20     
============================================
+ Hits          10795    11654     +859     
- Misses         7594     8304     +710     
- Partials        579      581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
Copy link

f2c-ci-robot bot commented May 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, wzrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit c1e8bdb into halo-dev:main May 24, 2024
8 checks passed
@JohnNiang JohnNiang modified the milestones: 2.16.x, 2.16.0 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Future] 希望增加定时发布的功能
5 participants