Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor api client using separated OpenAPI groups #6130

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Refactor api client using separated OpenAPI groups #6130

merged 2 commits into from
Jun 24, 2024

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Jun 24, 2024 •
edited by ruibaby
Loading

What type of PR is this?

/kind improvement
/kind cleanup
/kind api-change
/area core

What this PR does / why we need it:

This PR totally refactors API client using separated OpenAPI groups. We split all APIs into 4 parts:

  • Public-related API
  • Console-related API
  • User center-related API
  • Extension API

Does this PR introduce a user-facing change?

重构 OpenAPI 文档分组。

@JohnNiang
Refactor api client using separated OpenAPI groups
73ff69c 
Signed-off-by: JohnNiang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/core Issues or PRs related to the Halo Core labels Jun 24, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from johnniang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby changed the title WIP: Refactor api client using separated OpenAPI groups Refactor api client using separated OpenAPI groups Jun 24, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2024
@JohnNiang JohnNiang merged commit d451d56 into halo-dev:refactor/api-client Jun 24, 2024
1 check passed
@JohnNiang JohnNiang deleted the refactor/openapi branch June 24, 2024 08:43
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 26, 2024
This was referenced Jun 28, 2024
Closed
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Jun 28, 2024
@JohnNiang
Rectify role templates about PAT and 2FA endpoints (#6201)
c7bf87b 
#### What type of PR is this?

/kind bug
/area core
/milestone 2.17.x

#### What this PR does / why we need it:

In PR <#6130>, I changed the api group of PAT and 2FA endpoints, but I forgot to change the corresponding role templates. So other users except admin will encounter 403 error like <#6199>.

#### Which issue(s) this PR fixes:

Fixes #6199

#### Does this PR introduce a user-facing change?

```release-note
None
```
@ruibaby ruibaby mentioned this pull request Jun 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing Awaiting requested review from guqing

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees
No one assigned
Labels
area/core Issues or PRs related to the Halo Core kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnNiang @ruibaby