Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use top-level interface of session repository #6160

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind improvement
/area core
/milestone 2.17.x

What this PR does / why we need it:

Use top-level interface org.springframework.session.ReactiveFindByIndexNameSessionRepository for being compatible with other session repositories.

Which issue(s) this PR fixes:

Fixes #6159

Does this PR introduce a user-facing change?

None

Signed-off-by: JohnNiang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen June 27, 2024 03:12
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.93%. Comparing base (bc10336) to head (7e30b71).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6160      +/-   ##
============================================
+ Coverage     54.51%   56.93%   +2.42%     
- Complexity     3523     3706     +183     
============================================
  Files           646      652       +6     
  Lines         21862    22038     +176     
  Branches       1528     1537       +9     
============================================
+ Hits          11917    12547     +630     
+ Misses         9328     8883     -445     
+ Partials        617      608       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
Copy link

f2c-ci-robot bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 54cd1c8 into halo-dev:main Jun 27, 2024
7 checks passed
@f2c-ci-robot f2c-ci-robot bot added the triage/duplicate Indicates an issue is a duplicate of other open issue. label Jun 27, 2024
@guqing guqing removed the triage/duplicate Indicates an issue is a duplicate of other open issue. label Jun 27, 2024
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用redis作为缓存升级2.17.0-alpha.1后无法启动成功
3 participants