Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TemplateFooterProcessor extension point for extending footer tag content in theme #6191

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jun 28, 2024

What type of PR is this?

/kind feature
/area core
/milestone 2.17.x

What this PR does / why we need it:

提供对模板中 halo footer 标签内容的扩展点以支持扩展页脚内容

Which issue(s) this PR fixes:

Fixes #6189

Does this PR introduce a user-facing change?

提供对模板中 halo footer 标签内容的扩展点以支持扩展页脚内容

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby June 28, 2024 03:38
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.96%. Comparing base (bc10336) to head (185ba53).
Report is 49 commits behind head on main.

Files Patch % Lines
...eme/dialect/TemplateFooterElementTagProcessor.java 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6191      +/-   ##
============================================
+ Coverage     54.51%   57.96%   +3.45%     
- Complexity     3523     3751     +228     
============================================
  Files           646      649       +3     
  Lines         21862    21998     +136     
  Branches       1528     1539      +11     
============================================
+ Hits          11917    12751     +834     
+ Misses         9328     8628     -700     
- Partials        617      619       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
@ruibaby ruibaby added sig/docs Categorizes an issue or PR as relevant to SIG Docs. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
Copy link

f2c-ci-robot bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit f5ebd9f into halo-dev:main Jul 1, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jul 1, 2024
@guqing guqing deleted the feature/6189 branch July 2, 2024 03:38
f2c-ci-robot bot pushed a commit to halo-dev/docs that referenced this pull request Jul 2, 2024
### What this PR does?
为 TemplateFooterProcessor 添加开发文档

see also halo-dev/halo#6191

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望增加对主题端 footer 标签的内容扩展
3 participants