Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: keep the pluginWrapper bean for compatibility #6271

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 5, 2024

What type of PR is this?

/area core
/milestone 2.18.x

What this PR does / why we need it:

为了平滑升级先保留 PluginWrapper 的 Bean

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core release-note-none Denotes a PR that doesn't merit a release note. labels Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby July 5, 2024 03:06
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.21%. Comparing base (bc10336) to head (727fc4c).
Report is 63 commits behind head on main.

Files Patch % Lines
.../src/main/java/run/halo/app/plugin/BasePlugin.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6271      +/-   ##
============================================
+ Coverage     54.51%   58.21%   +3.70%     
- Complexity     3523     3759     +236     
============================================
  Files           646      647       +1     
  Lines         21862    21953      +91     
  Branches       1528     1541      +13     
============================================
+ Hits          11917    12779     +862     
+ Misses         9328     8554     -774     
- Partials        617      620       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
Copy link

f2c-ci-robot bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 138d52e into halo-dev:main Jul 5, 2024
7 checks passed
@guqing guqing deleted the refactor/base-plugin branch July 5, 2024 04:11
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants