-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove transactional annotation #6492
Conversation
9cf7cd4
to
94c07de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6492 +/- ##
============================================
+ Coverage 58.18% 58.23% +0.05%
Complexity 3774 3774
============================================
Files 651 651
Lines 22125 22125
Branches 1538 1538
============================================
+ Hits 12873 12885 +12
+ Misses 8641 8631 -10
+ Partials 611 609 -2 ☔ View full report in Codecov by Sentry. |
bf8cb39
to
c9cc12e
Compare
c9cc12e
to
383490f
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/area core
/milestone 2.19.x
What this PR does / why we need it:
移除事务注解避免对索引创建产生影响,原因参考改动中的方法注释
其中一点特别注意:
在执行
client.create(name, data)
方法后,会尝试进行indexer.indexRecord
操作。但 indexRecord 可能会因唯一索引中存在重复键而导致 indexRecord 失败,索引创建也会随之失败。为确保索引与数据的一致性,此时应回滚由client.create(name, data)
对数据产生的影响,因此除非找到更佳的一致性问题解决方案,否则暂时不能移除此处的手动事务操作。将变更传递给 extension watcher 是在
doCreate
或doUpdate
成功之后才会被处理,因此这里的事务回滚不会对 watcher 造成影响Does this PR introduce a user-facing change?