Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong condition in h2 warning alert #6526

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 26, 2024

What type of PR is this?

/area ui
/kind bug
/milestone 2.19.0

What this PR does / why we need it:

修复 H2 数据库提示判断有误的问题。

Does this PR introduce a user-facing change?

None

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 26, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.0 milestone Aug 26, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Aug 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and wzrove August 26, 2024 10:39
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 26, 2024
Copy link

sonarcloud bot commented Aug 26, 2024

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.82%. Comparing base (6cd8dc8) to head (f50d8ae).
Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6526      +/-   ##
============================================
- Coverage     58.18%   57.82%   -0.36%     
- Complexity     3774     3863      +89     
============================================
  Files           651      668      +17     
  Lines         22125    22829     +704     
  Branches       1538     1584      +46     
============================================
+ Hits          12873    13202     +329     
- Misses         8641     9008     +367     
- Partials        611      619       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2024
Copy link

f2c-ci-robot bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ab6c20a into halo-dev:main Aug 26, 2024
8 checks passed
@ruibaby ruibaby deleted the fix/h2-warning-alert branch August 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants