Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve axios instance parameters #6550

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 29, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.19.0

What this PR does / why we need it:

优化默认的 axios 实例的参数:

  1. baseURL 改为空字符串。
  2. 默认优化数组参数。

Does this PR introduce a user-facing change?

None

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note-none Denotes a PR that doesn't merit a release note. labels Aug 29, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.0 milestone Aug 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from Aanko August 29, 2024 08:56
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Aug 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang August 29, 2024 08:56
Copy link

sonarcloud bot commented Aug 29, 2024

Copy link

pkg-pr-new bot commented Aug 29, 2024

commit: 7604abb

@halo-dev/api-client

pnpm add https://pkg.pr.new/@halo-dev/api-client@6550

@halo-dev/components

pnpm add https://pkg.pr.new/@halo-dev/components@6550

@halo-dev/richtext-editor

pnpm add https://pkg.pr.new/@halo-dev/richtext-editor@6550

@halo-dev/console-shared

pnpm add https://pkg.pr.new/@halo-dev/console-shared@6550

@halo-dev/ui-plugin-bundler-kit

pnpm add https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@6550

Open in Stackblitz

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.93%. Comparing base (6cd8dc8) to head (7604abb).
Report is 40 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6550      +/-   ##
============================================
- Coverage     58.18%   57.93%   -0.25%     
- Complexity     3774     3878     +104     
============================================
  Files           651      670      +19     
  Lines         22125    22866     +741     
  Branches       1538     1550      +12     
============================================
+ Hits          12873    13248     +375     
- Misses         8641     9010     +369     
+ Partials        611      608       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 998f4cc into halo-dev:main Aug 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants