Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create OWNERS #8

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Create OWNERS #8

merged 1 commit into from
Apr 12, 2022

Conversation

JohnNiang
Copy link
Member

This PR is only for approving PR by commenting /approve and making PR merge automatically.

/kind chore
/cc @halo-dev/sig-halo

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 12, 2022

@JohnNiang: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

This PR is only for approving PR by commenting /approve and making PR merge automatically.

/kind chore
/cc @halo-dev/sig-halo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

guqing
guqing approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2022
@JohnNiang
Copy link
Member Author

I'm going to merge this PR manually due to missing OWNERS file.

@JohnNiang JohnNiang added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 08990d0 into main Apr 12, 2022
@JohnNiang JohnNiang deleted the JohnNiang-patch-1 branch April 12, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing approved these changes

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnNiang @guqing