Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 增加MySQL数据库支持 #5

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Conversation

wan92hen
Copy link
Member

@wan92hen wan92hen commented Jun 16, 2023

  1. 增加 MySQL 数据库部署支持
  2. 调整默认 Halo 镜像版本
None

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 16, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang June 16, 2023 10:49
@wan92hen
Copy link
Member Author

/hold

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2023
@wan92hen
Copy link
Member Author

- 更新 Halo 版本到 v2.6.1
- 增加 MySQL 数据库部署支持
- 增加检测数据库连通性的初始化容器

@wan92hen
Copy link
Member Author

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2023
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test steps:

gh repo clone halo-sigs/charts && cd charts
gh pr checkout 5
helm dependency build charts/halo
helm install halo -n halo charts/halo --create-namespace --set mysql.enabled=true --set postgresql.enabled=false
kubectl port-forward -n halo service/halo --address localhost 8090:http

Check the info of Halo:

{
  "git": {
    "branch": "HEAD",
    "commit": {
      "id": "15433b5",
      "time": "2023-06-14T10:20:14Z"
    }
  },
  "build": {
    "artifact": "application",
    "name": "application",
    "time": "2023-06-14T10:33:11.814Z",
    "version": "2.6.1",
    "group": "run.halo.app"
  },
  "java": {
    "version": "17.0.7",
    "vendor": {
      "name": "Eclipse Adoptium",
      "version": "Temurin-17.0.7+7"
    },
    "runtime": {
      "name": "OpenJDK Runtime Environment",
      "version": "17.0.7+7"
    },
    "jvm": {
      "name": "OpenJDK 64-Bit Server VM",
      "vendor": "Eclipse Adoptium",
      "version": "17.0.7+7"
    }
  },
  "os": {
    "name": "Linux",
    "version": "5.15.49-linuxkit-pr",
    "arch": "aarch64"
  },
  "database": {
    "name": "Source distribution",
    "version": "8.0.33"
  }
}

It works very well, but I left some comments below, please take a look at them.

charts/halo/values.yaml Outdated Show resolved Hide resolved
charts/halo/values.yaml Outdated Show resolved Hide resolved
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 28, 2023
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link
Contributor

f2c-ci-robot bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit ee216c9 into halo-sigs:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants