-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 增加MySQL数据库支持 #5
Conversation
wan92hen
commented
Jun 16, 2023
•
edited by JohnNiang
Loading
edited by JohnNiang
- 增加 MySQL 数据库部署支持
- 调整默认 Halo 镜像版本
/hold |
|
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test steps:
gh repo clone halo-sigs/charts && cd charts
gh pr checkout 5
helm dependency build charts/halo
helm install halo -n halo charts/halo --create-namespace --set mysql.enabled=true --set postgresql.enabled=false
kubectl port-forward -n halo service/halo --address localhost 8090:http
Check the info of Halo:
{
"git": {
"branch": "HEAD",
"commit": {
"id": "15433b5",
"time": "2023-06-14T10:20:14Z"
}
},
"build": {
"artifact": "application",
"name": "application",
"time": "2023-06-14T10:33:11.814Z",
"version": "2.6.1",
"group": "run.halo.app"
},
"java": {
"version": "17.0.7",
"vendor": {
"name": "Eclipse Adoptium",
"version": "Temurin-17.0.7+7"
},
"runtime": {
"name": "OpenJDK Runtime Environment",
"version": "17.0.7+7"
},
"jvm": {
"name": "OpenJDK 64-Bit Server VM",
"vendor": "Eclipse Adoptium",
"version": "17.0.7+7"
}
},
"os": {
"name": "Linux",
"version": "5.15.49-linuxkit-pr",
"arch": "aarch64"
},
"database": {
"name": "Source distribution",
"version": "8.0.33"
}
}
It works very well, but I left some comments below, please take a look at them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |